Open
Conversation
itrharrison
approved these changes
Mar 3, 2026
| ] | ||
| pyccl = [ | ||
| "pyccl>=3.1.2 ; sys_platform != 'win32' and python_version < '3.13'", # for stability | ||
| "pyccl @ git+https://github.com/LSSTDESC/CCL.git@master ; sys_platform != 'win32' and python_version < '3.13'", |
Collaborator
There was a problem hiding this comment.
We should be aware that we would no longer be able to deploy to pypi because of taking dependencies from git.
In person we discussed with @anicola that it is unlikely the pyccl pip package will continue to be maintained, but the conda one will.
I guess we could cheat the system a little by keeping these requirements out of our pyproject.toml but including them in the uv env(?). But of course then it would be very easy for a user to acquire a non-functioning installation via pip. If such a naive user exists(?)...
itrharrison
reviewed
Mar 3, 2026
| [tool.uv] | ||
| override-dependencies = [ | ||
| "tensorflow>=2.18", | ||
| "tensorflow-probability>=0.24", |
Collaborator
There was a problem hiding this comment.
Can @HTJense update these dependencies directly in https://github.com/HTJense/cosmopower/blob/main/requirements.txt too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @itrharrison @HTJense, here I tried to pull
cosmopowerfrom @HTJense's fork to check its compatibility with the rest of the code.Also, to update to numpy 2, I had to pull
pycclfrom git as the PyPI version was built against numpy 1.x, while the git one works fine with 2.x.This allowed to add support to Python 3.14 and to update many of our dependencies.
The new API of
cosmopowercaused a couple of issues, which should be solved now.In general, I am not a big fan of pulling dependencies from git as it is far less stable than PyPI, but as you know, this has become a critical issue, so we might have to come to terms with that.